-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: 'YYYY-MM-DD' as gantt default date format #6163
base: develop
Are you sure you want to change the base?
fix: 'YYYY-MM-DD' as gantt default date format #6163
Conversation
🦋 Changeset detectedLatest commit: 02efa03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6163 +/- ##
==========================================
- Coverage 4.47% 4.47% -0.01%
==========================================
Files 384 385 +1
Lines 54179 54190 +11
Branches 623 598 -25
==========================================
Hits 2425 2425
- Misses 51754 51765 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
📑 Summary
The Gantt chart diagram type documentation claims that "The default input date format is YYYY-MM-DD."
See document
However in actuality, an explicit dateFormay YYYY-MM-DD must be given for such dates to be recognized.
Resolves #5862 , #5655
📏 Design Decisions
I set default date format as "YYYY-MM-DD"
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.