-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Add ability to get classDefs from classDb #6190
base: develop
Are you sure you want to change the base?
chore: Add ability to get classDefs from classDb #6190
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6190 +/- ##
=======================================
Coverage 4.47% 4.47%
=======================================
Files 383 382 -1
Lines 54142 54138 -4
Branches 596 621 +25
=======================================
Hits 2425 2425
+ Misses 51717 51713 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
E2E tests failing as of right now due to argos but they should actually be good.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment
…/mermaid into chore/class_db_get_classdefs
📑 Summary
Creates and exposes public function to fetch classDefs inside the classDb. Also includes change to properly split styles when inserting into its object styles array.
📏 Design Decisions
getClassDefs() returns the defined style classes from inside the classDb so we have access to them.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.