Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make integration work on element that has syntax highlighting #6361

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

chrisirhc
Copy link

📑 Summary

This is a proof of concept of how to render code blocks with syntax highlighting.

Resolves #6360

📏 Design Decisions

Use the textContent attribute.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: 3c8cb60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 3c8cb60
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67cb017d50e59b00082dcd38
😎 Deploy Preview https://deploy-preview-6361--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6361
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6361
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6361
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6361

commit: 3c8cb60

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.88%. Comparing base (bc2bd3d) to head (3c8cb60).

Files with missing lines Patch % Lines
packages/mermaid/src/mermaid.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6361      +/-   ##
==========================================
- Coverage     3.88%   3.88%   -0.01%     
==========================================
  Files          398     399       +1     
  Lines        42044   42051       +7     
  Branches       638     638              
==========================================
  Hits          1635    1635              
- Misses       40409   40416       +7     
Flag Coverage Δ
unit 3.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/mermaid.ts 0.44% <0.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

argos-ci bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 200 changed, 17 removed, 36 failures Mar 7, 2025, 2:34 PM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mermaid default startOnLoad does not work on code blocks with syntax highlighting
1 participant