Fix dotted lines not appearing in flowcharts when HTML labels disabled #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, `edgeData.style` was being overwritten when it was already set earlier in the method.
|
Ping! |
|
Thanks! Merging! |
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Jun 25, 2019
This fixes dotted lines not rendering when the htmlLabels setting is false (mermaid-js/mermaid#828). Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60869
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Jun 26, 2019
This fixes dotted lines not rendering when the htmlLabels setting is false (mermaid-js/mermaid#828). Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60869
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Jun 26, 2019
This fixes dotted lines not rendering when the htmlLabels setting is false (mermaid-js/mermaid#828). Full list of changes: https://github.com/knsv/mermaid/releases Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60869
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Jun 27, 2019
This fixes dotted lines not rendering when the htmlLabels setting is false (mermaid-js/mermaid#828). Full list of changes: https://github.com/knsv/mermaid/releases Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60869
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Jul 2, 2019
This fixes dotted lines not rendering when the htmlLabels setting is false (mermaid-js/mermaid#828). Full list of changes: https://github.com/knsv/mermaid/releases Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60869
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
edgeData.stylewas being overwritten when itwas already set earlier in the method.