Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding components for older istio versions #266

Merged
merged 15 commits into from
Aug 26, 2021

Conversation

Shreyas220
Copy link
Member

@Shreyas220 Shreyas220 commented Aug 19, 2021

Signed-off-by: Shreyas220 shreyas.ny@gmail.com

Description
Add components for older istio versions

This PR fixes #265

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@welcome
Copy link

welcome bot commented Aug 19, 2021

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@leecalcote
Copy link
Member

Cool!

@leecalcote leecalcote added the area/lifecycle Lifecycle management (install, uninstall, configure) related label Aug 20, 2021
@leecalcote
Copy link
Member

@killbotXD heads-up: the need for managing the display of versioned components coming to a Designer near you.

@killbotXD
Copy link

Yeah we will definitely do something about that too.

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@leecalcote
Copy link
Member

1,323 files. Wow.

@Shreyas220
Copy link
Member Author

Shreyas220 commented Aug 23, 2021

1,323 files. Wow.

heh 😅
also @leecalcote @DelusionalOptimist till what versions should i generate these ?

@DelusionalOptimist
Copy link
Contributor

I wonder what version of Istio are real world people using 😛

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@tangledbytes
Copy link
Contributor

tangledbytes commented Aug 25, 2021

Hold this for a day or two

PS: Good to go 👍

@leecalcote
Copy link
Member

yay! 🎈

@leecalcote leecalcote merged commit 144e0af into meshery:master Aug 26, 2021
@welcome
Copy link

welcome bot commented Aug 26, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/components area/lifecycle Lifecycle management (install, uninstall, configure) related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Patterns] Add components for older istio versions
5 participants