Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

StoreForward: replace "empty" by "text" and improve comments #437

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

GUVWAF
Copy link
Member

@GUVWAF GUVWAF commented Feb 10, 2024

This will replace the currently unused "empty" variant of the StoreForward message to "text", such that clients know how to handle the history from the server. Technically a breaking change, but the "empty" variant was not used in the firmware.

Also updated some of the comments of other fields.

@thebentern thebentern merged commit 6cb1878 into meshtastic:master Feb 10, 2024
1 check failed
@andrekir
Copy link
Member

@GUVWAF what do you think of having both a text_broadcast and text_direct oneOf added?

this way we can separate broadcasts from direct messages like the Delayed field was designed (below): text_broadcast we replace the to with the broadcast node number; text_direct is a DM for us.

we would then need to pick the oneOf based on packetHistoryTXQueue[packetHistory_index].to here

enum Delayed {
/*
* If unset, the message is being sent in real time.
*/
NO_DELAY = 0;
/*
* The message is delayed and was originally a broadcast
*/
DELAYED_BROADCAST = 1;
/*
* The message is delayed and was originally a direct message
*/
DELAYED_DIRECT = 2;
}

@GUVWAF
Copy link
Member Author

GUVWAF commented Feb 11, 2024

Good idea. Or should we add two RequestResponse tags instead? One for text_direct and one for text_broadcast? Currently I'm using the UNSET.

@andrekir
Copy link
Member

Good idea. Or should we add two RequestResponse tags instead? One for text_direct and one for text_broadcast? Currently I'm using the UNSET.

commented on meshtastic/firmware#3194 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants