Fix typo when fetching buildtype option for compiler checks #7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type happened in mesonbuild#7432 and wasn't noticed because I didn't add a test for it. Rectified now. If we don't specify the CRT, MSVC will pick /MT by default (!?) and link to `libcmt.lib`. This actually *breaks* UWP because `libcmt.lib` is not available by default when building for UWP. Was noticed here: cisco/libsrtp#505
nirbheek
force-pushed
the
fix-vscrt-compiler-checks
branch
from
e210975 to
1a481d6
Compare
|
Still works fine with Windows arm64 native build (gst-build) 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This typo happened in #7432 and wasn't noticed because I didn't add a test for it. Rectified now.
If we don't specify the CRT, MSVC will pick
/MTby default (!?) and link tolibcmt.lib. This actually breaks UWP becauselibcmt.libis not available by default when building for UWP.Was noticed here: cisco/libsrtp#505