Add a mode to prevent polling the master state. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkleiman @philipnrmn This PR adds a flag with the same functionality as in #69. I'd prefer to make this change independently of the other changes in the #69 branch. |
If we poll the master's `/state` endpoint on large clusters, we can degrade master performance. Since the `/state` endpoint is used to generate per-agent resource metrics, and we can already get those by running the exporter on each agent, add a new flag that can disable the collection of these metrics.
ryodocx
pushed a commit
to ryodocx/mesos_exporter
that referenced
this pull request
Mar 18, 2019
Add a mode to prevent polling the master state.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we poll the master's
/stateendpoint on large clusters, we candegrade master performance. Since the
/stateendpoint is used togenerate per-agent resource metrics, and we can already get those
by running the exporter on each agent, add a new flag that can
disable the collection of these metrics.
This is equivalent to the fix in #69