Update to mupdf v1.26.0-rc1 and fix leak #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, oh well. I don't really know where this failure is coming from, especially since there are many reports of a 256 byte and two 32 byte objects leaking. Idk which of those are the same, but it's at least not sth that's our fault. Maybe there is a way to disable ASAN warning us about those specific leaks or leaks coming from fontconfig, as completly disabling the ASAN CI would be quite bad. |
This reverts commit 6579d8d.
messense
approved these changes
May 7, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the work done in #129 but up-to-date with main and fixing the leak ASAN detected.
Currently the tests fail as a
compile_faildoctest introduced in #121 now compiles on nightly (on stable it still fails). Will investigate later.