-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update dependencies and submodules #31
Conversation
I think this might not be safe to merge because change and/or add new non-optional attributes. Since sir pre-generates the XML documents that conform to the MB schema and the QueryWriter classes in this repository de-serialize, annotate and re-serialize those, merging this means that sir would write documents into Solr that can't be de-serialized by the JAXB bindings (I think, or maybe it just ignores missing values). In order to get a version of sir that writes values that the newer JAXB binding can read, https://github.com/metabrainz/mb-rngpy also needs to be updated, as well as the code in https://github.com/metabrainz/sir/blob/master/sir/wscompat/convert.py that touches the affected XML elements, at least the following:
and rebuild all indexes that include the affected elements :-( 9231758 looks fine. |
The other dependencies(apart from the lucene/solr on es) that you updated - how did come to those versions?. If they don't match the ones use in docker solr, it will fail with a bunch of errors due to multiple conflicting packages. Edit - Ah I see you used mvn versions plugin - that won't work. I can explain this better on irc later if you want. |
Yes, I used Versions Plugin with maven. |
Updates:
Still missing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes and the steps you'll take after merging look good to me!
Update git submodule 'mbsssss' to tag v-2019-06-17 and git submodule 'mmd-schema' to tag v-2019-01-07.
Dependencies checked with https://mvnrepository.com/artifact/org.apache.solr/solr-core/7.7.2
Dependencies checked with https://mvnrepository.com/artifact/org.eclipse.persistence/eclipselink/2.7.4
Update:
Actions to be taken after merge: