Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update dependencies and submodules #31

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Conversation

yvanzo
Copy link
Contributor

@yvanzo yvanzo commented Jan 29, 2019

Update:

  • Apache Solr to (latest 7.x version) 7.7.2 (checked upgrade notes to 7.6.0, 7.7.0, 7.7.1, and 7.7.2);
  • EclipseLink to 2.7.4;
  • mbsssss to latest tag v-2019-06-17;
  • mmd-schema to latest tag v-2019-01-07.

Actions to be taken after merge:

  • Releasing a new version of mb-solr;
  • Updating musicbrainz-docker (and musicbrainz-vm later on);
  • Updating mb-solr-cloud;
  • Deploying sir and mb-solr-cloud;
  • Reindexing.

@mineo
Copy link
Member

mineo commented Jan 30, 2019

I think this might not be safe to merge because

change and/or add new non-optional attributes. Since sir pre-generates the XML documents that conform to the MB schema and the QueryWriter classes in this repository de-serialize, annotate and re-serialize those, merging this means that sir would write documents into Solr that can't be de-serialized by the JAXB bindings (I think, or maybe it just ignores missing values). In order to get a version of sir that writes values that the newer JAXB binding can read, https://github.com/metabrainz/mb-rngpy also needs to be updated, as well as the code in https://github.com/metabrainz/sir/blob/master/sir/wscompat/convert.py that touches the affected XML elements, at least the following:

and rebuild all indexes that include the affected elements :-(

9231758 looks fine.

@sambhav
Copy link
Contributor

sambhav commented Jan 30, 2019

The other dependencies(apart from the lucene/solr on es) that you updated - how did come to those versions?. If they don't match the ones use in docker solr, it will fail with a bunch of errors due to multiple conflicting packages.

Edit - Ah I see you used mvn versions plugin - that won't work. I can explain this better on irc later if you want.

@yvanzo
Copy link
Contributor Author

yvanzo commented Jan 31, 2019

Yes, I used Versions Plugin with maven.

@yvanzo
Copy link
Contributor Author

yvanzo commented May 16, 2019

Updates:

  • Java dependencies have been updated without using Versions Plugin or Maven;
  • mb-rngpy has been updated to bind the latest mmd-schema 2.0 v-2019-01-07 in PR Update to MMD schema 2.0 v-2019-01-07  mb-rngpy#3 and released as version 2.20190107.0 on both GitHub and PyPI;
  • SIR has been updated to use that version of mb-rngpy in Update SIR to MMD schema 2.0 v-2019-01-07 sir#103,
    it has been updated to use more recent PySolr bindings and the latest mbdata 25.0.0 bindings too.
    (Note: database schema change 25 did not impact mmd-schema for now.)

Still missing:

Copy link
Member

@mineo mineo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and the steps you'll take after merging look good to me!

yvanzo added a commit to yvanzo/musicbrainz-docker that referenced this pull request Jun 5, 2019
yvanzo added a commit to yvanzo/musicbrainz-docker that referenced this pull request Jun 5, 2019
yvanzo added a commit to yvanzo/musicbrainz-docker that referenced this pull request Jun 5, 2019
yvanzo added a commit to yvanzo/musicbrainz-docker that referenced this pull request Jun 6, 2019
@yvanzo yvanzo requested review from zas and removed request for zas June 17, 2019 13:08
@yvanzo yvanzo merged commit 3c62b07 into metabrainz:master Jun 17, 2019
@yvanzo yvanzo deleted the updepsub branch June 17, 2019 13:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants