Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing examples for fix functions and additional some old workshop examples as use cases #180

Merged
merged 7 commits into from
Aug 23, 2024

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jul 2, 2024

For the old workshop examples.
See #175

@TobiasNx TobiasNx requested a review from fsteeg July 2, 2024 14:39
@fsteeg
Copy link
Member

fsteeg commented Jul 2, 2024

Test are failing. From the logs one problem seemed to be to_base64, and indeed if I try to run that that example it fails. Same on test, which uses a newer metafix version. It seems the examples use functionality that's not in main (yet?). Do you have a local Playground running to test this?

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Jul 2, 2024
@dr0i
Copy link
Member

dr0i commented Jul 2, 2024

I've updated test-PG. See the mentioned to_base64 now ok.

@dr0i dr0i assigned fsteeg and unassigned TobiasNx Jul 2, 2024
@fsteeg
Copy link
Member

fsteeg commented Jul 3, 2024

Looks good on deployed Playground, but this PR is failing.

If I understand it correctly what's missing here is the update to current fix & core.

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Jul 3, 2024
@TobiasNx TobiasNx mentioned this pull request Aug 22, 2024
3 tasks
@TobiasNx
Copy link
Contributor Author

@fsteeg could you have another look!

@TobiasNx
Copy link
Contributor Author

When good, need to update the documentation.

Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TobiasNx TobiasNx merged commit f248b64 into main Aug 23, 2024
2 checks passed
@TobiasNx TobiasNx deleted the addMoreExamples branch August 23, 2024 08:34
This was linked to issues Sep 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing examples Workshop examples are gone
3 participants