Skip to content

Iframe fix #900

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Iframe fix #900

wants to merge 1 commit into from

Conversation

wayheming
Copy link

Fix for #861

@desandro desandro self-assigned this Feb 11, 2019
@desandro
Copy link
Member

desandro commented Feb 11, 2019

Thanks for this. I'll look to add this to fizzy-ui-utils

Add a 👍 reaction to this issue if you would like to see Flickity have better support for Elementor. Do not add +1 comments — They will be deleted.

@wayheming
Copy link
Author

@desandro
Thank you very much I will wait for your decision

@desandro
Copy link
Member

Per Elementor team, HTMLElement should still be available. elementor/elementor#6756 (comment)

Not sure why you say that HTMLElement doesn't exist in elementor, HTMLElement is a native browser function which identify HTML elements and Elementor works with and around HTML elements.

Maybe you can chime in on this thread and help explain the situation.

@wayheming
Copy link
Author

Hello @desandro I answered in the repository of the Elementor and provided a test site.

@desandro
Copy link
Member

Thank you for your help here!

@DeoThemes
Copy link

DeoThemes commented Jan 26, 2021

I wonder when this will be implemented? I found this is the only solution to make Flickity work properly in Elementor editor.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants