Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add antimicrobial resistance annotations #23

Merged
merged 13 commits into from
Dec 21, 2023
Merged

Add antimicrobial resistance annotations #23

merged 13 commits into from
Dec 21, 2023

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Dec 18, 2023

With this PR we add a pipeline to extract AMR annotations using the AMRFinderPlus software and add them to the database. I also added the annotations to the locus and orthogroup views.

Also note that:

  • currently only docker is supported, will add conda support later.
  • I had to fix a few f-strings that got broken by autopep8. It seems that pycodestyle does not correctly support f-strings.

Screenshot of the annotations on a locus tag view
AMR_locus_view

We add a new argument --amr argument to the run script and use
amrfinder to search for antibiotics resistances when the argument
is set. For now, amrfinder can only be run as a container.
This is a temporary hack that allows to add zDB specific methods
to the DB class. In future refactoring we will move at least
part of the db_utils to the zDB repo so will see then what
refactoring is necessary.
These URLs were broken by auto PEP8 formatting.
This is necessary to be able to import the zdb.database module.
It seems pycodestyle has a bug in handling f-strings with format
specifiers, introducing white space after the colon
@njohner njohner requested a review from tpillone December 18, 2023 07:25
@tpillone
Copy link
Contributor

Nice work!
I would remove the scope and add the gene symbol to the table (with a link to the NCBI entry of the HMM, e.g https://www.ncbi.nlm.nih.gov/genome/annotation_prok/evidence/NF033374/)

@njohner
Copy link
Contributor Author

njohner commented Dec 21, 2023

Ok I've added the gene with a link to the HMM profile, but I left the "scope" column, as this is pretty important (if unclear). I've added a tooltip to the table to send users to the AMRFinderPlus documentation for more information on the fields.

@njohner njohner merged commit 3c6e68f into master Dec 21, 2023
@njohner njohner deleted the nj/resistance branch December 21, 2023 14:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants