Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix blast view #64

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Fix blast view #64

merged 5 commits into from
Mar 1, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Feb 28, 2024 •
edited
Loading

Blast view was broken because of two things:

Checklist

  • Changelog entry
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

@njohner
Fix bug in blast view.
12ccddf 
ffn and fna databases used to be inverted which was fixed in pull
request 17 but the fix got lost in the rebase of PR 22.
@njohner
Clean-up blast view template.
00557eb 
The venn diagram never gets plotted as the necessary variable
series is never in the context.
@njohner njohner requested review from bkm and tpillone February 28, 2024 15:25
@njohner njohner merged commit 60ca059 into master Mar 1, 2024
@njohner njohner deleted the nj/fix_blast branch March 1, 2024 11:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tpillone tpillone tpillone approved these changes

@bkm bkm Awaiting requested review from bkm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njohner @tpillone