Handle groups when selecting genomes wherever pertinent. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njohner
force-pushed
the
nj/groups_in_forms
branch
from
7bf22cf to
1c835c9
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we now allow selecting groups in the forms wherever pertinent, notably in all the comparison views and the plot region view.
Of note is that we lost the "all" and "None" buttons in the process, which are not built-in with select2 and not that easy to implement with choices being fetched with asynchronous requests. I think this is OK though as groups allow for easy selection and I will implement group management next.
Checklist