Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix various views for cases where there are no gene annotations. #99

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Fix various views for cases where there are no gene annotations. #99

merged 4 commits into from
Jul 2, 2024

Conversation

njohner
Copy link
Contributor

@njohner njohner commented Jul 2, 2024 •
edited
Loading

With this PR we fix various bugs in views that fail when there are no gene annotations. Indeed we had cases where the gene column was entirely missing in the dataframe because it did not appear in any of the query results, which led to failing views. We fix that case for

  • search_bar results
  • extract_contigs view
  • locusx view

Resolves #96

Checklist

  • Changelog entry
  • Check that tests still pass
  • Add tests for new features and regression tests for bugfixes whenever possible.

njohner added 2 commits July 2, 2024 09:29
@njohner
Fix extract_contigs view error for contigs without any gene annotation.
70f9aae 
If all loci did not have a gene, the column was missing in the
returned dataframe, leading to an error in the view. We now make
sure that all requested columns are present.
@njohner
Fix locusx view error for loci with homologs without any gene annotat…
c80b444 
…ion.
@njohner njohner changed the title Fix extract_contigs view error for contigs without any gene annotation. Fix various views for cases where there are no gene annotations. Jul 2, 2024
@njohner njohner merged commit 87e353a into master Jul 2, 2024
@njohner njohner deleted the nj/fix_bugs branch July 2, 2024 09:16
This was referenced Jul 2, 2024
Closed
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError at /search_bar 'name'
1 participant
@njohner