Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

FS-910 Add Bom router and server for API getBmcMacAddrr #6

Merged
merged 2 commits into from
Sep 13, 2023
Merged

FS-910 Add Bom router and server for API getBmcMacAddrr #6

merged 2 commits into from
Sep 13, 2023

Conversation

Alva8756
Copy link
Collaborator

This is a follow up PR from #2 for getBmcMacAddrr API

Test

  • Tested with unit test
  • Tested in local environment with the flow: curl -> bomservice -> serverservice -> crdb
  • get: curl localhost:9003/api/v1/bomservice/bmc-mac-address/B1 -v

@Alva8756 Alva8756 marked this pull request as ready for review September 12, 2023 05:43
joelrebel
joelrebel reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Alva, I've left a few comments

@Alva8756 Alva8756 requested a review from joelrebel September 13, 2023 17:10
joelrebel
joelrebel approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Alva8756 Alva8756 merged commit 7b3d8a9 into metal-toolbox:main Sep 13, 2023
@Alva8756 Alva8756 changed the title Add Bom router and server for API getBmcMacAddrr FS-910 Add Bom router and server for API getBmcMacAddrr Sep 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@joelrebel joelrebel joelrebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alva8756 @joelrebel