Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

✨ Add new CRD for FirmwareComponents Update #1501

Merged
merged 1 commit into from
Jan 29, 2024
Merged

✨ Add new CRD for FirmwareComponents Update #1501

merged 1 commit into from
Jan 29, 2024

Conversation

iurygregory
Copy link
Member

@iurygregory iurygregory commented Dec 29, 2023 •
edited
Loading

This PR adds a new CRD for the HostFirmwareComponents described in the Firmware Interface proposal - metal3-io/metal3-docs#364.

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 29, 2023
@iurygregory iurygregory force-pushed the hostfirmwarecomponents-CRD branch 2 times, most recently from a0fa687 to d89e8ad Compare January 15, 2024 14:44
@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@iurygregory iurygregory changed the title ✨ Add new CRD for Firmware Components Update ✨ Add new CRD for FirmwareComponents Update Jan 15, 2024
@iurygregory
Copy link
Member Author

/metal3-bmo-e2e-test

1 similar comment
@tuminoid
Copy link
Member

/metal3-bmo-e2e-test

@tuminoid
Copy link
Member

/metal3-bmo-e2e-test

Oh you meant the action based e2e. I re-ran that as well, in progress right now.

@iurygregory iurygregory force-pushed the hostfirmwarecomponents-CRD branch from d89e8ad to 9584a9b Compare January 18, 2024 16:21
@iurygregory
Add new CRD for Firmware Components Update
7a29244 
Add a new CRD for the HostFirmwareComponents described
in the Firmware Interface proposal - metal3-io/metal3-docs#364.

Signed-off-by: Iury Gregory Melo Ferreira <imelofer@redhat.com>
@iurygregory iurygregory force-pushed the hostfirmwarecomponents-CRD branch from 9584a9b to 7a29244 Compare January 18, 2024 16:31
@iurygregory
Copy link
Member Author

/test-centos-e2e-integration-main
/test-ubuntu-integration-main
/metal3-bmo-e2e-test

@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-optional-test

@metal3-io-bot
Copy link
Contributor

@iurygregory: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test generate
  • /test gofmt
  • /test golint
  • /test gomod
  • /test gosec
  • /test manifestlint
  • /test markdownlint
  • /test metal3-bmo-e2e-test-pull
  • /test shellcheck
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gofmt
  • golint
  • gomod
  • gosec
  • manifestlint
  • unit

In response to this:

/test metal3-bmo-e2e-optional-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-bmo-e2e-optional-test-pull

@iurygregory
Copy link
Member Author

/test metal3-bmo-e2e-test-optional-pull

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
dtantsur
dtantsur reviewed Jan 29, 2024
View reviewed changes
apis/metal3.io/v1alpha1/hostfirmwarecomponents_types.go
}

// Check whether the updates's names are valid
func (host *HostFirmwareComponents) ValidateHostFirmwareComponents() error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea for a follow-up: move this to the driver level. Since this is, in fact, driver specific.

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@metal3-io-bot metal3-io-bot merged commit 5a6b6ef into metal3-io:main Jan 29, 2024
17 checks passed
@iurygregory iurygregory deleted the hostfirmwarecomponents-CRD branch April 5, 2024 16:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iurygregory @tuminoid @metal3-io-bot @elfosardo @dtantsur