Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

🌱 Update to the Gophercloud beta.4+commits #1696

Merged
merged 2 commits into from
Apr 25, 2024
Merged

🌱 Update to the Gophercloud beta.4+commits #1696

merged 2 commits into from
Apr 25, 2024

Conversation

dtantsur
Copy link
Member

It keeps changing, now they reworked the HTTP error handling, so

  1. switch to the new helper function,
  2. stop relying on the exact error message in tests,
  3. modernize the touched code a bit.

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

@dtantsur
Update to the latest Gophercloud
687565f 
It keeps changing, now they reworked the HTTP error handling, so
1) switch to the new helper function,
2) stop relying on the exact error message in tests,
3) modernize the touched code a bit.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2024
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main

tuminoid
tuminoid reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question

@tuminoid
Copy link
Member

/ok-to-test
to make prow happy.

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 24, 2024
@tuminoid
Copy link
Member

/retitle 🌱 Update to the Gophercloud beta.4+commits

@metal3-io-bot metal3-io-bot changed the title 🌱 Update to the latest Gophercloud 🌱 Update to the Gophercloud beta.4+commits Apr 24, 2024
lentzi90
lentzi90 reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
tuminoid
tuminoid reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
/cc @lentzi90

@metal3-io-bot metal3-io-bot requested a review from lentzi90 April 25, 2024 10:18
@hardys
Copy link
Member

hardys commented Apr 25, 2024

/lgtm

@metal3-io-bot
Copy link
Contributor

@hardys: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member Author

/hold

Found one issue

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@dtantsur
Fix reporting errors from changeNodeProvisionState
f12ed28 
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test metal3-centos-e2e-integration-test-main
/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

1 similar comment
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@metal3-io-bot metal3-io-bot merged commit 24ab906 into metal3-io:main Apr 25, 2024
17 checks passed
@dtantsur dtantsur deleted the gophercloud branch April 25, 2024 14:50
@tuminoid tuminoid mentioned this pull request Aug 13, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@hroyrh hroyrh hroyrh left review comments

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dtantsur @tuminoid @metal3-io-bot @hardys @elfosardo @lentzi90 @hroyrh