Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

🌱 Export BuildKustomizeManifest and GetKubeconfigPath functions in E2E #1738

Merged
merged 1 commit into from
May 21, 2024
Merged

🌱 Export BuildKustomizeManifest and GetKubeconfigPath functions in E2E #1738

merged 1 commit into from
May 21, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented May 20, 2024

These functions are useful and can be used in other packages as well. For e.g. #1669

@metal3-io-bot metal3-io-bot requested review from lentzi90 and Rozzii May 20, 2024 14:01
@mquhuy
Copy link
Member Author

mquhuy commented May 20, 2024

/test ?

@metal3-io-bot
Copy link
Contributor

@mquhuy: The following commands are available to trigger required jobs:

  • /test generate
  • /test gomod
  • /test manifestlint
  • /test markdownlint
  • /test metal3-bmo-e2e-test-pull
  • /test shellcheck
  • /test test
  • /test unit

The following commands are available to trigger optional jobs:

  • /test metal3-bmo-e2e-test-optional-pull
  • /test metal3-centos-e2e-basic-test-main
  • /test metal3-centos-e2e-feature-test-main
  • /test metal3-centos-e2e-integration-test-main
  • /test metal3-dev-env-integration-test-centos-main
  • /test metal3-dev-env-integration-test-ubuntu-main
  • /test metal3-e2e-1-26-1-27-upgrade-test-main
  • /test metal3-e2e-1-27-1-28-upgrade-test-main
  • /test metal3-e2e-1-28-1-29-upgrade-test-main
  • /test metal3-e2e-clusterctl-upgrade-test-main
  • /test metal3-ubuntu-e2e-basic-test-main
  • /test metal3-ubuntu-e2e-feature-test-main
  • /test metal3-ubuntu-e2e-integration-test-main

Use /test all to run the following jobs that were automatically triggered:

  • generate
  • gomod
  • manifestlint
  • unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2024
@mquhuy
Copy link
Member Author

mquhuy commented May 20, 2024

/test metal3-bmo-e2e-test-pull metal3-bmo-e2e-test-optional-pull

@mquhuy mquhuy force-pushed the mquhuy/make-e2e-func-public branch from a9d58df to 1fffad5 Compare May 20, 2024 14:20
@mquhuy
Copy link
Member Author

mquhuy commented May 20, 2024

/test metal3-bmo-e2e-test-pull metal3-bmo-e2e-test-optional-pull

@mquhuy
Copy link
Member Author

mquhuy commented May 21, 2024

/cc @kashifest @tuminoid @adilGhaffarDev @smoshiur1237 @mboukhalfa

@Rozzii
Copy link
Member

Rozzii commented May 21, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
tuminoid
tuminoid reviewed May 21, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

smoshiur1237
smoshiur1237 reviewed May 21, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@metal3-io-bot metal3-io-bot merged commit f164adc into metal3-io:main May 21, 2024
16 of 17 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/make-e2e-func-public branch May 21, 2024 06:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@lentzi90 lentzi90 Awaiting requested review from lentzi90

@Rozzii Rozzii Awaiting requested review from Rozzii

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@kashifest kashifest Awaiting requested review from kashifest

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mquhuy @metal3-io-bot @Rozzii @kashifest @tuminoid @smoshiur1237