Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🌱 Reuse PR verifier workflow from project-infra #1968

Merged

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Sep 19, 2024

Reuse PR verifier workflow from project-infra, so it is easier to maintain in a single place and reduces number of dependabot bump PRs targeting Github Actions, creating less noise.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2024
@mquhuy mquhuy force-pushed the mquhuy/use-pr-verifier-from-project-infra branch 15 times, most recently from 8bc3e21 to 321b936 Compare September 19, 2024 09:11
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/retitle 🌱 Use PR verifier from project-infra [WIP]

@metal3-io-bot metal3-io-bot changed the title Use PR verifier from project-infra [test] 🌱 Use PR verifier from project-infra [WIP] Sep 19, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/retitle Use PR verifier from project-infra

@metal3-io-bot metal3-io-bot changed the title 🌱 Use PR verifier from project-infra [WIP] Use PR verifier from project-infra Sep 19, 2024
@mquhuy mquhuy force-pushed the mquhuy/use-pr-verifier-from-project-infra branch from 321b936 to 27f657d Compare September 19, 2024 09:15
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/retitle 🌱 Use PR verifier from project-infra [WIP]

@metal3-io-bot metal3-io-bot changed the title Use PR verifier from project-infra 🌱 Use PR verifier from project-infra [WIP] Sep 19, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/retitle Use PR verifier from project-infra

@metal3-io-bot metal3-io-bot changed the title 🌱 Use PR verifier from project-infra [WIP] Use PR verifier from project-infra Sep 19, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/retitle 🌱 Use PR verifier from project-infra [WIP]

@metal3-io-bot metal3-io-bot changed the title Use PR verifier from project-infra 🌱 Use PR verifier from project-infra [WIP] Sep 19, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/retitle Use PR verifier from project-infra

@metal3-io-bot metal3-io-bot changed the title Use PR verifier from project-infra 🌱 Use PR verifier from project-infra Sep 19, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/retitle Use PR verifier from project-infra

@metal3-io-bot metal3-io-bot changed the title 🌱 Use PR verifier from project-infra Use PR verifier from project-infra Sep 19, 2024
@mquhuy mquhuy force-pushed the mquhuy/use-pr-verifier-from-project-infra branch from 27f657d to f00df49 Compare September 19, 2024 09:21
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/retitle 🌱 Use PR verifier from project-infra

@metal3-io-bot metal3-io-bot changed the title Use PR verifier from project-infra 🌱 Use PR verifier from project-infra Sep 19, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 19, 2024

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2024
@mquhuy mquhuy force-pushed the mquhuy/use-pr-verifier-from-project-infra branch 2 times, most recently from 3087746 to 513b14f Compare September 19, 2024 09:25
@mquhuy mquhuy force-pushed the mquhuy/use-pr-verifier-from-project-infra branch 6 times, most recently from 92feceb to c2ee9d1 Compare September 19, 2024 12:28
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/use-pr-verifier-from-project-infra branch from c2ee9d1 to e663baf Compare September 19, 2024 12:29
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle 🌱 Reuse PR verifier workflow from project-infra
/lgtm

@metal3-io-bot metal3-io-bot changed the title 🌱 Use PR verifier from project-infra 🌱 Reuse PR verifier workflow from project-infra Sep 20, 2024
@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Oct 14, 2024

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@metal3-io-bot metal3-io-bot merged commit f2fe1ff into metal3-io:main Oct 24, 2024
35 of 37 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/use-pr-verifier-from-project-infra branch October 24, 2024 06:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants