Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

📖 Add e2e status badge to readme #2064

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

lentzi90
Copy link
Member

What this PR does / why we need it:

This adds status badges for all e2e tests on the main branch. We could consider adding badges also for the release branches, but it may become hard to read with so many badges.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2024
@tuminoid
Copy link
Member

This adds status badges for all e2e tests on the main branch. We could consider adding badges also for the release branches, but it may become hard to read with so many badges.

This is one thing we have updated in release branches in the past: the badges. Feel free to make PR to release branches to add their specific badge there instead of main.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@tuminoid
Copy link
Member

/retitle 📖 Add e2e status badge to readme

@metal3-io-bot metal3-io-bot changed the title 🌱 Add e2e status badge to readme 📖 Add e2e status badge to readme Nov 20, 2024
@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@metal3-io-bot metal3-io-bot merged commit 568ba96 into metal3-io:main Nov 20, 2024
9 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/add-e2e-status-badge branch November 20, 2024 06:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants