Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(hook): add nan_to_num hooks #119

Merged
merged 7 commits into from
Nov 19, 2022
Merged

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added enhancement New feature or request feature New feature labels Nov 18, 2022
Benjamin-eecs
Benjamin-eecs previously approved these changes Nov 19, 2022
@Benjamin-eecs Benjamin-eecs removed the request for review from waterhorse1 November 19, 2022 13:48
waterhorse1
waterhorse1 previously approved these changes Nov 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2022

Codecov Report

Base: 64.87% // Head: 64.67% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (842953b) compared to base (f831b53).
Patch coverage: 42.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   64.87%   64.67%   -0.20%     
==========================================
  Files          65       66       +1     
  Lines        2804     2828      +24     
==========================================
+ Hits         1819     1829      +10     
- Misses        985      999      +14     
Flag Coverage Δ
unittests 64.67% <42.30%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/transform/nan_to_num.py 31.25% <31.25%> (ø)
torchopt/hook.py 42.85% <42.85%> (-0.90%) ⬇️
torchopt/__init__.py 100.00% <100.00%> (ø)
torchopt/transform/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@XuehaiPan XuehaiPan merged commit 05e0f3f into metaopt:main Nov 19, 2022
@XuehaiPan XuehaiPan deleted the nan-to-num branch November 19, 2022 16:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants