Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(workflows): rewrite setup CUDA Toolkit logic #133

Merged
merged 3 commits into from
Feb 12, 2023

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

The GitHub Action seems out of maintenance.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Base: 70.35% // Head: 70.35% // No change to project coverage 👍

Coverage data is based on head (f4831ea) compared to base (773d140).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files          72       72           
  Lines        3009     3009           
=======================================
  Hits         2117     2117           
  Misses        892      892           
Flag Coverage Δ
unittests 70.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@XuehaiPan XuehaiPan self-assigned this Feb 12, 2023
@XuehaiPan XuehaiPan added enhancement New feature or request cxx / cuda Something related to the CXX / CUDA extension dependencies Pull requests that update a dependency file labels Feb 12, 2023
@XuehaiPan XuehaiPan merged commit b8939ca into metaopt:main Feb 12, 2023
@XuehaiPan XuehaiPan deleted the setup-cuda-toolkit branch February 12, 2023 14:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cxx / cuda Something related to the CXX / CUDA extension dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants