Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix HTTP Error Handling added in #100 #101

Merged
merged 6 commits into from
Feb 17, 2023

Conversation

Funkatronics
Copy link
Contributor

Description

  • Fixed up error handling in JdkHttpDriver

Work Completed

API Changes

  • none

Testing

  • ran all unit tests, verified that this change does not impact any existing calls or error handling
  • confirmed this change works locally by simulating bad requests

@Funkatronics Funkatronics changed the title fix http error handling Fix HTTP Error Handling added in #100 Feb 17, 2023
@Funkatronics
Copy link
Contributor Author

Sorry @ajamaica, mad a mistake in my previous PR!

Big thanks to @creativedrewy for catching this!

@Funkatronics Funkatronics changed the title Fix HTTP Error Handling added in #100 [WIP] Fix HTTP Error Handling added in #100 Feb 17, 2023
@ajamaica
Copy link
Contributor

Please rebase

@Funkatronics Funkatronics changed the title [WIP] Fix HTTP Error Handling added in #100 Fix HTTP Error Handling added in #100 Feb 17, 2023
@Funkatronics
Copy link
Contributor Author

Help me obi wan jamacia, you're my only hope 🙏🏽

@ajamaica
Copy link
Contributor

The issue is the transfer airdrop the code it's fine. We can merge it

@ajamaica ajamaica merged commit 0aa7adf into main Feb 17, 2023
@Funkatronics Funkatronics deleted the martini/fix-http-error-handling-my-mistake branch February 17, 2023 20:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants