Implement cond #15
Open
Implement cond #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonid-shutov
commented
Dec 15, 2024
| @@ -16,3 +16,19 @@ test('Translate LISP to JavaScript', () => { | |||
| const expected = 22; | |||
| assert.strictEqual(result, expected); | |||
| }); | |||
|
|
|||
| test('Translate LISP condition to JavaScript', () => { | |||
| // TODO: replace with comparison operators when they are implemented | |||
There was a problem hiding this comment.
I could use eq here but it doesn't transform properly #14
leonid-shutov
force-pushed
the
main
branch
2 times, most recently
from
73e1160 to
f768415
Compare
leonid-shutov
commented
Dec 20, 2024
lib/expressions.js
Outdated
Comment on lines
75
to
80
| let header = '('; | ||
|
|
||
| for (const identifier of this.identifiers) { | ||
| if (header.length > 1) { | ||
| header += ', '; | ||
| } | ||
| header += identifier; | ||
| } | ||
|
|
||
| header += ')'; | ||
|
|
||
| return `${header} => ${this.toExpression()}`; | ||
| } |
There was a problem hiding this comment.
avoid creating an extra array as Murych suggested
leonid-shutov
commented
Dec 20, 2024
| } else if (operand instanceof OperationExpression) { | ||
| for (const name of operand.identifiers.values()) { | ||
| if (operand.identifiers !== undefined) { | ||
| for (const name of operand.identifiers) { |
There was a problem hiding this comment.
I think information expert works well here
leonid-shutov
commented
Dec 20, 2024
Comment on lines
+113
to
+115
| // eslint-disable-next-line consistent-return | ||
| interpret(context) { | ||
| for (const { condition, consequents } of this.clauses) { | ||
| if (condition.interpret(context) !== false) { | ||
| return consequents.reduce( | ||
| (_, consequent) => consequent.interpret(context), | ||
| undefined, | ||
| ); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Lisp returns nil if there are no matches. What behavior do we expect? Currently it returns undefined in this case
tshemsedinov
requested changes
Jan 13, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9
npm t)npm run fix)