feat!: v1 #1
feat!: v1 #1
Conversation
index.js
Outdated
|
|
||
| module.exports = fp( | ||
| function fastifyRacePlugin (fastify, globalOpts, next) { | ||
| const controllers = new Map() |
There was a problem hiding this comment.
This looks very leak-prone. Maybe use a WeakMap instead?
There was a problem hiding this comment.
I was thinking about that at the first iteration, but I wasn't sure under which circumstances the onResponse cannot be called so the Map is not cleaned properly. But I think for avoiding unexpected issues would be better to go with a WeakMap as you suggested
There was a problem hiding this comment.
Btw, here is what do you recommend to use the key for the WeakMap? My initial thought is to take advantage of the request, as is ready to be gc'ed once the request is done. wdyt?
|
Hi @mcollina please have a look, I refactored the implementation to use WeakMaps instead, thanks for the feedback 🙂 |
|
Merging now, please feel free to provide more feedback afterwards 🙂 |
Pending