Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update blaze package to es6 #437

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Update blaze package to es6 #437

merged 3 commits into from
Dec 29, 2023

Conversation

StorytellerCZ
Copy link
Collaborator

Taking inspiration from #397, migrate blaze package in a smaller way to ES6.

Also update dependencies.

@jankapunkt
Copy link
Collaborator

Most of the tests fail on view.setAttributes I think this is a scoping issue, as with #436

@StorytellerCZ
Copy link
Collaborator Author

I will play around with this part. I saw it in the original PR, but I probably got too excited about this, so I will revert to the original code.

packages/blaze/lookup.js Outdated Show resolved Hide resolved
@StorytellerCZ
Copy link
Collaborator Author

@radekmie @jankapunkt let's create a new 2.x release with these PRs and the async PRs that are already in master.

@jankapunkt
Copy link
Collaborator

@StorytellerCZ I agree but I also just got confirmation that #426 is working stable so we should get this in the next 2.x release so let's add this fix, too

@StorytellerCZ StorytellerCZ added this to the 2.8 milestone Dec 22, 2023
@Grubba27 Grubba27 merged commit 14b57bd into master Dec 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants