-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Docs: Added jsDoc #144
Docs: Added jsDoc #144
Conversation
published a release |
I do some testing with |
Got a little trouble building with expo, because I also import |
Is there a specific error? |
If I do |
You have to Edit: since it's tagged as |
I get
because I also have |
ah I see, this is a peer dependency conflict, let me check, if I can resolve this quickly |
Can we simply add a |
Could build it with the added peerDep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs are great, maybe at some point we could add a git workflow to auto-generate docs and deploy on github pages
I'd like to report that removing NetInfo in my staging environment seems to solve a problem that occurred randomly and is still hard to reproduce. Namely, on iOS, when bringing the app back up from (suspended) background, the user did not log back in, although the socket was connected. Now I manage connection / disconnecting via rn AppState, look good so far. |
Great! We should add that to the docs, like a troubleshooting section. Something like "if you have trouble with reconnecting,.try Appstate instead of NetInfo. Here is a minimal example:...". Do you have the time and will to add this section to this PR? |
@bratelefant we will add Troubleshooting / FAQ in another PR, would you mind adding a review in the meantime? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, forgot to approve. Changes reviewed and looking good.
We can merge this, will add my |
Thanks 👍 |
Summary
Adds jsDoc to build and code
Linked issue(s)
partially #141 in order to improve documentation for better logging
Involved parts of the project
Added tests?
no extra tests
Targeted Meteor release version
Reproduction
clone repo, checkout
docs/jsdoc
and runnpm run build:docs