Hotfix/automation custom script.sh #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteocarnelos
requested changes
Jan 6, 2024
There was a problem hiding this comment.
I finally had time to test and review the changes suggested in this PR.
Thanks for the fix! However, following some testing, the automation script needs some more fixes. For example, Grafana deprecated the grafana-cli utility that we are using.
I'll follow with a new PR after this one with these fixes and update sailtrack-ground accordingly.
For this PR, overall it's great! I just highlighted some nits.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue 24
Before merging, I recommend testing the changes on the real system to ensure everything works as expected.