Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix reference to OBS_VERT_TYPES_ALT #1405

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Nov 15, 2024

Change Summary

Fixes small issue with OBS_VERT_TYPES_ALT which is no longer on Colocator but ColocationSetup.

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@thorbjoernl thorbjoernl marked this pull request as ready for review November 15, 2024 10:22
@thorbjoernl thorbjoernl added the bug 🐛 Something isn't working label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (3bc258a) to head (eac30f2).
Report is 367 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/colocation/colocator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1405   +/-   ##
=========================================
  Coverage     78.58%   78.58%           
=========================================
  Files           137      137           
  Lines         20899    20899           
=========================================
  Hits          16423    16423           
  Misses         4476     4476           
Flag Coverage Δ
unittests 78.58% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@lewisblake lewisblake merged commit b15dadf into main-dev Nov 18, 2024
7 of 8 checks passed
@lewisblake lewisblake deleted the fix-obs-vert-types-alt branch November 18, 2024 08:12
@heikoklein heikoklein added this to the m2024-12 milestone Jan 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants