Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Delete failed messages on subscriber deletion #110

Merged
merged 5 commits into from
Mar 8, 2021
+57 −1
Merged

Delete failed messages on subscriber deletion #110

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95a1848
Delete failed messages on subscriber deletion
willselby Feb 26, 2021
5184051
Move failed deletion to message class
willselby Mar 5, 2021
e0cf360
Add tests and add loop for message deletion
Mar 5, 2021
9a2639a
Favour mass deletion
Mar 5, 2021
960b56c
Access relationship instance instead of collection
Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Models/Subscriber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ function ($model) {
static::deleting(
function (self $subscriber) {
$subscriber->tags()->detach();

$subscriber->messages()->each(function (Message $message) {
$message->failures()->delete();
});

$subscriber->messages()->delete();
}
);
Expand Down