Self-host CSS and JS assets #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving away from using CDNs for hosting assets, as there is no real advantage to doing so for an application like SendPortal, while having all the disadvantages of CDNs. This also upgrades some of the versions to the latest available. We have decided for now not to build the assets ourselves, as we didn't want to take on the maintenance burden of a more complex build process, without any immediately obvious benefit. However, we should occasionally look to see if there are more up-to-date versions to pull in, and perhaps can reconsider building it ourselves in the future.
mauricius
approved these changes
Jul 5, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving away from using CDNs for hosting assets, as there is no real
advantage to doing so for an application like SendPortal, while
having all the disadvantages of CDNs.
This also upgrades some of the versions to the latest available.
We have decided for now not to build the assets ourselves, as we
didn't want to take on the maintenance burden of a more complex
build process, without any immediately obvious benefit. However,
we should occasionally look to see if there are more up-to-date
versions to pull in, and perhaps can reconsider building it
ourselves in the future.
Triggered by issue #124