Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX: Go to app base url #29

Merged
merged 2 commits into from
Jun 22, 2020
Merged

FIX: Go to app base url #29

merged 2 commits into from
Jun 22, 2020

Conversation

jinjie
Copy link
Contributor

@jinjie jinjie commented Jun 12, 2020

Clicking on the logo should always go to the app base url

@joshuafranks
Copy link
Contributor

Hi @jinjie,

What are the motivations behind this proposed change? Are you suggesting that we make the logo's hyperlink respect the APP_URL specified in your .env file?

@jinjie
Copy link
Contributor Author

jinjie commented Jun 12, 2020 via email

@joshuafranks
Copy link
Contributor

OK, cool. Figured as such.

We had not previously considered the possibility that some deployments would be made in virtual directories and there are other areas of the application that rely on root-relative URLs. This could, in theory, present other issues. We'll chat about this internally on Monday and get back to you with a complete solution that ensures support for your use-case. I'll keep this open in the mean time.

@JonoB JonoB added this to the v1.0.2 milestone Jun 16, 2020
@JonoB JonoB requested review from dljfield and mauricius June 22, 2020 11:49
@JonoB JonoB merged commit b254805 into mettle:master Jun 22, 2020
@jinjie jinjie deleted the fix-appurl branch June 22, 2020 13:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants