Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Delete segment #36

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Delete segment #36

merged 2 commits into from
Jul 10, 2020

Conversation

willselby
Copy link
Contributor

Story

mettle/sendportal#43

Description

Enable segments to be deleted through the UI.

@willselby willselby requested a review from mauricius July 10, 2020 10:00
@JonoB JonoB self-requested a review July 10, 2020 10:57
@JonoB JonoB requested a review from dljfield July 10, 2020 14:13
dljfield
dljfield approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@dljfield dljfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to have a test for completeness sake (tests/Feature/Segments/SegmentsControllerTest.php) but code looks good and works.

@JonoB
Copy link
Contributor

JonoB commented Jul 10, 2020

@willselby can you add a test for deletion, and then merge pls.

@willselby willselby merged commit 0e239ed into master Jul 10, 2020
@willselby willselby deleted the delete-segment branch July 10, 2020 15:26
@JonoB JonoB added this to the v1.0.3 milestone Jul 11, 2020
@JonoB JonoB mentioned this pull request Jul 11, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dljfield dljfield dljfield approved these changes

@JonoB JonoB JonoB approved these changes

@mauricius mauricius Awaiting requested review from mauricius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@willselby @JonoB @dljfield