Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix count unique opens per period in Postgres #53

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Fix count unique opens per period in Postgres #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Repositories/Messages/PostgresMessageTenantRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ class PostgresMessageTenantRepository extends BaseMessageTenantRepository
public function countUniqueOpensPerPeriod(int $workspaceId, string $sourceType, int $sourceId, int $intervalInSeconds): Collection
{
return DB::table('messages')
->select(DB::raw("COUNT(*) as open_count, MIN(opened_at) as opened_at, round(extract('epoch' from opened_at) / $intervalInSeconds) * $intervalInSeconds as period_start"))
->selectRaw("COUNT(*) as open_count, MIN(opened_at) as opened_at, to_char(to_timestamp(floor(extract('epoch' from opened_at) / $intervalInSeconds) * $intervalInSeconds),'YYYY-MM-DD HH24:MI:SS') as period_start")
->where('workspace_id', $workspaceId)
->where('source_type', $sourceType)
->where('source_id', $sourceId)
->whereNotNull('opened_at')
->groupBy(DB::raw("round(extract('epoch' from opened_at) / " . $intervalInSeconds . ")"))
->groupByRaw("floor(extract('epoch' from opened_at) / $intervalInSeconds)")
->orderBy('opened_at')
->get();
}
Expand Down
187 changes: 187 additions & 0 deletions tests/Unit/Repositories/MessageTenantRepositoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,187 @@
<?php

namespace Tests\Unit\Repositories;

use Carbon\CarbonImmutable;
use Carbon\CarbonInterval;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Collection;
use Sendportal\Base\Models\Campaign;
use Sendportal\Base\Models\Message;
use Sendportal\Base\Models\Workspace;
use Sendportal\Base\Repositories\Messages\MessageTenantRepositoryInterface;
use Sendportal\Base\Repositories\Messages\MySqlMessageTenantRepository;
use Sendportal\Base\Repositories\Messages\PostgresMessageTenantRepository;
use Tests\SendportalTestSupportTrait;
use Tests\TestCase;

class MessageTenantRepositoryTest extends TestCase
{
use RefreshDatabase;

/**
* @var MySqlMessageTenantRepository|PostgresMessageTenantRepository
*/
protected $repository;

public function setUp(): void
{
parent::setUp();

$this->repository = app()->make(MessageTenantRepositoryInterface::class);
}

/** @test */
function it_should_not_count_messages_that_have_not_been_opened_yet()
{
$workspace = factory(Workspace::class)->create();

$campaign = factory(Campaign::class)->create([
'workspace_id' => $workspace->id
]);

factory(Message::class, 2)->create([
'workspace_id' => $workspace->id,
'source_id' => $campaign->id,
]);

$data = $this->repository->countUniqueOpensPerPeriod($workspace->id, get_class($campaign), $campaign->id, CarbonInterval::day()->totalSeconds);

$this->assertInstanceOf(Collection::class, $data);
$this->assertTrue($data->isEmpty());
}

/** @test */
function it_should_count_messages_that_have_been_opened_grouped_by_day_period()
{
$opened_at = CarbonImmutable::create(2020, 05, 9, 20);

$workspace = factory(Workspace::class)->create();

$campaign = factory(Campaign::class)->create([
'workspace_id' => $workspace->id
]);

// 20 - 21 - 22 - 23
foreach (range(0, 3) as $i) {
factory(Message::class)->create([
'workspace_id' => $workspace->id,
'source_id' => $campaign->id,
'opened_at' => $opened_at->addHours($i)
]);
}

// 24
$next_opened_at = $opened_at->addHours(4);

factory(Message::class)->create([
'workspace_id' => $workspace->id,
'source_id' => $campaign->id,
'opened_at' => $next_opened_at
]);

$data = $this->repository->countUniqueOpensPerPeriod($workspace->id, get_class($campaign), $campaign->id, CarbonInterval::day()->totalSeconds);

$this->assertEquals(2, $data->count());

$this->assertEquals(4, $data->first()->open_count);
$this->assertEquals($opened_at->toDateTimeString(), $data->first()->opened_at);
$this->assertEquals($opened_at->startOfDay()->toDateTimeString(), $data->first()->period_start);

$this->assertEquals(1, $data->last()->open_count);
$this->assertEquals($next_opened_at->toDateTimeString(), $data->last()->opened_at);
$this->assertEquals($next_opened_at->startOfDay()->toDateTimeString(), $data->last()->period_start);
}

/** @test */
function it_should_count_messages_that_have_been_opened_grouped_by_two_hours_period()
{
$opened_at = CarbonImmutable::create(2020, 05, 9, 20);

$workspace = factory(Workspace::class)->create();

$campaign = factory(Campaign::class)->create([
'workspace_id' => $workspace->id
]);

// 20 - 21 - 22 - 23
foreach (range(0, 3) as $i) {
factory(Message::class)->create([
'workspace_id' => $workspace->id,
'source_id' => $campaign->id,
'opened_at' => $opened_at->addHours($i)
]);
}

// 24
$next_opened_at = $opened_at->addHours(4);

factory(Message::class)->create([
'workspace_id' => $workspace->id,
'source_id' => $campaign->id,
'opened_at' => $next_opened_at
]);

$data = $this->repository->countUniqueOpensPerPeriod($workspace->id, get_class($campaign), $campaign->id, CarbonInterval::hours(2)->totalSeconds);

$this->assertEquals(3, $data->count());

// 20
$this->assertEquals(2, $data[0]->open_count);
$this->assertEquals($opened_at->toDateTimeString(), $data[0]->opened_at);
$this->assertEquals($opened_at->toDateTimeString(), $data[0]->period_start);

// 22
$this->assertEquals(2, $data[0]->open_count);
$this->assertEquals($opened_at->addHours(2)->toDateTimeString(), $data[1]->opened_at);
$this->assertEquals($opened_at->addHours(2)->toDateTimeString(), $data[1]->period_start);

// 24
$this->assertEquals(1, $data[2]->open_count);
$this->assertEquals($next_opened_at->toDateTimeString(), $data[2]->opened_at);
$this->assertEquals($next_opened_at->startOfDay()->toDateTimeString(), $data[2]->period_start);
}

/** @test */
function it_should_count_messages_that_have_been_opened_grouped_by_hour_period()
{
$opened_at = CarbonImmutable::create(2020, 05, 9, 20);

$workspace = factory(Workspace::class)->create();

$campaign = factory(Campaign::class)->create([
'workspace_id' => $workspace->id
]);

// 20 - 21 - 22 - 23
foreach (range(0, 3) as $i) {
factory(Message::class)->create([
'workspace_id' => $workspace->id,
'source_id' => $campaign->id,
'opened_at' => $opened_at->addHours($i)
]);
}

// 24
$next_opened_at = $opened_at->addHours(4);

factory(Message::class)->create([
'workspace_id' => $workspace->id,
'source_id' => $campaign->id,
'opened_at' => $next_opened_at
]);

$data = $this->repository->countUniqueOpensPerPeriod($workspace->id, get_class($campaign), $campaign->id, CarbonInterval::hour()->totalSeconds);

$this->assertEquals(5, $data->count());

foreach (range(0, 3) as $i) {
$this->assertEquals(1, $data[$i]->open_count);
$this->assertEquals($opened_at->addHours($i)->toDateTimeString(), $data[$i]->period_start);
}

$this->assertEquals(1, $data->last()->open_count);
$this->assertEquals($next_opened_at->toDateTimeString(), $data->last()->opened_at);
$this->assertEquals($next_opened_at->startOfDay()->toDateTimeString(), $data->last()->period_start);
}
}