fix: Fix some more inventory bugs #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardize usage of count=0 to signify empty inventory slots, with no additional requirement around the item ID in that case. Further, improve encode/decode of slots with this new definition. Finally, fix the slot range used by the player inventory "set slot" callback which prevented properly moving armor items around.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize usage of count=0 to signify empty inventory slots, with no additional requirement around the item ID in that case. Further, improve encode/decode of slots with this new definition. Finally, fix the slot range used by the player inventory "set slot" callback which prevented properly moving armor items around.