Ignore (possibly malformed) options after EOL #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is invalid for options (other than EOL) to occur after EOL. However, most network stacks will stop processing options at EOL, meaning that any further options will be ignored, including if they make the options field malformed. We should likewise stop processing at EOL as otherwise we will reject packets that most network stacks accept. Similarly, when writing out options use EOL as end padding, instead of NOP. Test.
|
This makes sense. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is invalid for options (other than EOL) to occur after EOL. However,
most network stacks will stop processing options at EOL, meaning that
any further options will be ignored, including if they make the options
field malformed. We should likewise stop processing at EOL as otherwise
we will reject packets that most network stacks accept.
Similarly, when writing out options use EOL as end padding, instead of
NOP.
Test.