Add RTP support #530
Merged
Add RTP support #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfontanini
reviewed
Mar 17, 2024
jamestiotio
force-pushed
the
rtp
branch
4 times, most recently
from
52c4117 to
6c662d4
Compare
|
I have improved the code to ensure that it's RFC-compliant by throwing a |
jamestiotio
force-pushed
the
rtp
branch
2 times, most recently
from
491daa2 to
d6c7296
Compare
mfontanini
reviewed
Mar 30, 2024
This commit adds support for the Real-time Transport Protocol (RTP) as defined in RFC 3550. Some tests have also been added to ensure that the RTP PDU class functionality is working as expected. Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
mfontanini
approved these changes
Mar 31, 2024
|
Awesome, thanks for staying on top of the PR and sorry again for the delay! |
|
No worries, thank you for your time! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the Real-time Transport Protocol (RTP) as defined in RFC 3550. Some tests have also been added to ensure that the RTP PDU class functionality is working as expected.
Note to reviewer: please double-check the parts that handle endian conversions. Initially, I was a little confused regarding the conversions. While I eventually managed to wrap my head around it, ensuring that the implementation handles these conversions correctly would be really appreciated. Thank you!