Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle jdt:// attachments on multiple clients #493

Merged
merged 2 commits into from
May 23, 2023
Merged

Handle jdt:// attachments on multiple clients #493

merged 2 commits into from
May 23, 2023

Conversation

fengwk
Copy link
Contributor

@fengwk fengwk commented May 22, 2023

I often need to switch between multiple workspaces, so multiple clients are generated.

I need a way to select the client that matches the expected behavior for attach, most of the cases I encounter jump to the buffer pointed to by the jdt protocol, so maybe acquiring the previous buffer’s client for attach might better match expectations.

It’s working fine, at least for now.

@fengwk
Copy link
Contributor Author

fengwk commented May 22, 2023

To add the reason for this change:

Before the modification, the contents of the jdt buffer using the wrong client will be decompiled instead of opening the source code.

@mfussenegger mfussenegger merged commit 365811e into mfussenegger:master May 23, 2023
@mfussenegger
Copy link
Owner

Makes sense to me. I made a couple of changes (and hope I didn't break it with them) and merged it.

@fengwk
Copy link
Contributor Author

fengwk commented May 23, 2023

Great, it's working fine now

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants