Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Internal visiblility #100

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Internal visiblility #100

merged 2 commits into from
Feb 13, 2019

Conversation

LokiMidgard
Copy link
Contributor

I noticed that I implemented AssemblyVisible only for classes. enum and interfaces are still public.

This change should fix that, but one of the new tests fails because of SourceUri property is empty string on attributeGroupRef. I don't think this has something todo with the changes I did. But parse operation in the test that I use wrong.
The xml from the text comes from a project where it is working, so that should be fine.

If someone can give me a hint what I need to change so the last test passes I would appreciate that.

Interfaces is failing because of SourceUri not set on attributeGroupRef. Don't know why 🤔
@LokiMidgard
Copy link
Contributor Author

LokiMidgard commented Feb 9, 2019

The Exception occurs here

if (_configuration.GenerateInterfaces)
{
CreateTypeModel(new Uri(attributeGroupRef.SourceUri), AttributeGroups[attributeGroupRef.RefName], attributeGroupRef.RefName);
}

Message: System.UriFormatException : Invalid URI: The URI is empty.

@mganss mganss merged commit 9fba85a into mganss:master Feb 13, 2019
@mganss
Copy link
Owner

mganss commented Feb 13, 2019

The SourceUri is empty at this point because the source comes from a string, not an actual uri (i.e. file). There were several places where we just blindly new'ed up a Uri. I've added a helper method CreateUri that takes null and empty strings into account.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants