Handle "0-1" definitions of boolean in .xsd #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 96.98% 96.99% +0.01%
==========================================
Files 17 17
Lines 2950 2961 +11
==========================================
+ Hits 2861 2872 +11
Misses 89 89
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 96.98% 96.99% +0.01%
==========================================
Files 17 17
Lines 2950 2961 +11
==========================================
+ Hits 2861 2872 +11
Misses 89 89
Continue to review full report at Codecov.
|
|
Thanks! Released in 2.0.212. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I've been doing C# development for a variety of XML services, and I occasionally encounter a schema definition that uses numeral 1 or 0 to define true/false.
I recently have been working on a project that uses that same kind of schema definition, and your utility has been able to handle complex, interlocking definitions a lot better than any other FOSS tool that I've come across. However, I had to make this small change to complete the code generation.
I'm submitting this PR in order to give back to the project.