Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add interface for NamingProvider and expand its use. #106

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Add interface for NamingProvider and expand its use. #106

merged 2 commits into from
Mar 11, 2019

Conversation

RedX2501
Copy link
Contributor

@RedX2501 RedX2501 commented Mar 8, 2019

Use INamingProvider to also be able to change the class names from their
names in the XSD.

The idea is to be able to change the name of the whole class if necessary.
For example remove all underscores.

Use INamingProvider to also be able to change the class names from their
names in the XSD.

The idea is to be able to change the name of the whole class if necessary.
For example remove all underscores.
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #106 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   97.13%   97.15%   +0.02%     
==========================================
  Files          17       17              
  Lines        2964     2988      +24     
==========================================
+ Hits         2879     2903      +24     
  Misses         85       85
Impacted Files Coverage Δ
XmlSchemaClassGenerator/Generator.cs 75.55% <ø> (ø) ⬆️
XmlSchemaClassGenerator/GeneratorConfiguration.cs 95.23% <100%> (ø) ⬆️
XmlSchemaClassGenerator/NamingProvider.cs 100% <100%> (ø) ⬆️
XmlSchemaClassGenerator/ModelBuilder.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bbf481...0947135. Read the comment docs.

@mganss
Copy link
Owner

mganss commented Mar 8, 2019

Very good idea. In the default NamingProvider, can you extract the qualifiedName.Name.ToTitleCase(NamingScheme.PascalCase); into a single virtual method and make the other ones virtual as well, so people can you use them as a starting point?

@mganss mganss merged commit bf49971 into mganss:master Mar 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants