Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

any attribute is not rendered if complex type extends other complex type #284

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

gureedo
Copy link

@gureedo gureedo commented Sep 2, 2021

  • any attribute is not rendered if complex type extends other complex type
  • fix GlobalReference mode (global:: gets rendered twice, collection of XmlAttribute rendered without global:: prefix)
  • fix duplicate backed value name

@gureedo gureedo marked this pull request as draft September 2, 2021 17:30
@gureedo gureedo changed the title fix code generation with CodeTypeReferenceOptions.GlobalReference mode any attribute is not rendered if complex type extends other complex type Sep 6, 2021
@gureedo gureedo marked this pull request as ready for review September 6, 2021 10:59
@gureedo gureedo marked this pull request as draft September 6, 2021 11:42
@gureedo gureedo marked this pull request as ready for review September 6, 2021 13:10
@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #284 (bb89889) into master (c7f5dcd) will increase coverage by 0.02%.
The diff coverage is 95.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   95.30%   95.33%   +0.02%     
==========================================
  Files          19       19              
  Lines        3238     3279      +41     
  Branches      471      479       +8     
==========================================
+ Hits         3086     3126      +40     
  Misses         90       90              
- Partials       62       63       +1     
Impacted Files Coverage Δ
XmlSchemaClassGenerator/ModelBuilder.cs 96.88% <89.47%> (-0.17%) ⬇️
XmlSchemaClassGenerator/CodeUtilities.cs 95.11% <100.00%> (+0.09%) ⬆️
XmlSchemaClassGenerator/TypeModel.cs 96.89% <100.00%> (+0.04%) ⬆️
XmlSchemaClassGenerator/Generator.cs 82.60% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f5dcd...bb89889. Read the comment docs.

@mganss
Copy link
Owner

mganss commented Sep 7, 2021

Thanks @gureedo Is this ready for merging?

@gureedo
Copy link
Author

gureedo commented Sep 7, 2021

Yes!

@mganss mganss merged commit 74feff9 into mganss:master Sep 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants