Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add original XSD elements to INamingProvider methods #295

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

aparshin
Copy link
Contributor

Fixes #293.

Note that this is not a backward-compatible improvement (INamingProvider interface is changed). Unfortunately, I don't have any good ideas on how to make it backward-compatible (except a separate interface and new configuration option, which looks pretty silly to me).

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #295 (f1bc752) into master (9c6f1dc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files          19       19           
  Lines        3286     3286           
  Branches      478      478           
=======================================
  Hits         3133     3133           
  Misses         90       90           
  Partials       63       63           
Impacted Files Coverage Δ
XmlSchemaClassGenerator/ModelBuilder.cs 96.90% <100.00%> (ø)
XmlSchemaClassGenerator/NamingProvider.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6f1dc...f1bc752. Read the comment docs.

@mganss mganss merged commit c9268e6 into mganss:master Nov 30, 2021
@mganss
Copy link
Owner

mganss commented Nov 30, 2021

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set different names for properties with the same qualified name in different classes?
2 participants