Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed NRT issues and tidied code. #336

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

las-nsc
Copy link
Contributor

@las-nsc las-nsc commented Jun 7, 2022

Fixes #332 and #333

While I was at it, I couldn't help myself from modernising and tidying up the code:

  • Avoid hard-coded strings.
  • new()
  • pattern matching
  • helper methods to avoid duplication

Removed about 500 lines of code.

All tests passing except XsdElsterDatenabholung5.CanCompileClasses due to missing files.

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #336 (4a9afce) into master (85dcbb4) will decrease coverage by 0.25%.
The diff coverage is 94.61%.

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   95.78%   95.53%   -0.26%     
==========================================
  Files          19       19              
  Lines        3371     3021     -350     
  Branches      496      464      -32     
==========================================
- Hits         3229     2886     -343     
+ Misses         82       76       -6     
+ Partials       60       59       -1     
Impacted Files Coverage Δ
XmlSchemaClassGenerator/CodeUtilities.cs 92.16% <90.82%> (-2.54%) ⬇️
XmlSchemaClassGenerator/RestrictionModel.cs 89.36% <95.00%> (-5.29%) ⬇️
XmlSchemaClassGenerator/TypeModel.cs 96.82% <96.02%> (+0.02%) ⬆️
XmlSchemaClassGenerator/ModelBuilder.cs 97.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85dcbb4...4a9afce. Read the comment docs.

@mganss
Copy link
Owner

mganss commented Jun 7, 2022

Thanks. I don't see any failing tests. Can this be merged?

@las-nsc
Copy link
Contributor Author

las-nsc commented Jun 7, 2022

I'm happy to if you're not bothered about the -0.26% code coverage

@mganss mganss merged commit 4a9afce into mganss:master Jun 7, 2022
@las-nsc las-nsc deleted the las/nrt-fixes-and-code-tidy branch July 6, 2022 12:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List<T> is nullable when using -nr
2 participants