Add support for nested non-nullable choice members #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 95.53% 95.55% +0.01%
==========================================
Files 19 19
Lines 3044 3057 +13
Branches 465 468 +3
==========================================
+ Hits 2908 2921 +13
Misses 78 78
Partials 58 58
Continue to review full report at Codecov.
|
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339.
Previously only direct children of choices would be forced to nullable (see how choices are handled in XmlSchemaClassGenerator). This pull request adds support to force nested descendants of choices to nullable if needed.