Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support to restricted collection item size #510

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Tarig0
Copy link

@Tarig0 Tarig0 commented May 22, 2024

This is a real quick re-apply of some code that I used to add support for collections with a specified min/max occurs as well as a primitive type that has its own restrictions.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.37%. Comparing base (e835215) to head (d0d01a7).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
XmlSchemaClassGenerator/TypeModel.cs 96.70% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage   94.21%   94.37%   +0.16%     
==========================================
  Files          21       21              
  Lines        3148     3238      +90     
  Branches      496      507      +11     
==========================================
+ Hits         2966     3056      +90     
  Misses        118      118              
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tarig0 Tarig0 marked this pull request as ready for review June 11, 2024 19:16
@mganss
Copy link
Owner

mganss commented Jun 14, 2024

Is this ready to merge?

@Tarig0 Tarig0 changed the title [Draft] Add support to restricted collection item size Add support to restricted collection item size Jun 17, 2024
@Tarig0
Copy link
Author

Tarig0 commented Jun 17, 2024

Functionally ready but could use a flag\check to only generate the simple types when they are required/useful. Current example if the user doesn't want data-annotation, I can't think of a reason to use the simple types.

I also want to auto generate implicit casts but that seems to be a bit to much to put in this PR

@mganss
Copy link
Owner

mganss commented Jun 17, 2024

Functionally ready but could use a flag\check to only generate the simple types when they are required/useful. Current example if the user doesn't want data-annotation, I can't think of a reason to use the simple types.

So perhaps they should be enabled by default if DataAnnotations are enabled and disabled by default if DataAnnotations are disabled?

I also want to auto generate implicit casts but that seems to be a bit to much to put in this PR

That would be great. Let me know when you want to merge.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants