Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): update dependency standard-version to v8 [security] #972

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 13, 2020

This PR contains the following updates:

Package Type Update Change
standard-version devDependencies major 7.1.0 -> 8.0.1

GitHub Vulnerability Alerts

GHSA-7xcx-6wjh-7xp2

GitHub Security Lab (GHSL) Vulnerability Report: GHSL-2020-111

The GitHub Security Lab team has identified a potential security vulnerability in standard-version.

Summary

The standardVersion function has a command injection vulnerability. Clients of the standard-version library are unlikely to be aware of this, so they might unwittingly write code that contains a vulnerability.

Product

Standard Version

Tested Version

Commit 2f04ac8

Details

Issue 1: Command injection in standardVersion

The following proof-of-concept illustrates the vulnerability. First install Standard Version and create an empty git repo to run the PoC in:

npm install standard-version
git init
echo "foo" > foo.txt # the git repo has to be non-empty
git add foo.txt
git commit -am "initial commit"

Now create a file with the following contents:

var fs = require("fs");
// setting up a bit of environment
fs.writeFileSync("package.json", '{"name": "foo", "version": "1.0.0"}');

const standardVersion = require('standard-version')

standardVersion({
  noVerify: true,
  infile: 'foo.txt',
  releaseCommitMessageFormat: "bla `touch exploit`"
})

and run it:

node test.js

Notice that a file named exploit has been created.

This vulnerability is similar to command injection vulnerabilities that have been found in other Javascript libraries. Here are some examples:
CVE-2020-7646,
CVE-2020-7614,
CVE-2020-7597,
CVE-2019-10778,
CVE-2019-10776,
CVE-2018-16462,
CVE-2018-16461,
CVE-2018-16460,
CVE-2018-13797,
CVE-2018-3786,
CVE-2018-3772,
CVE-2018-3746,
CVE-2017-16100,
CVE-2017-16042.

We have written a CodeQL query, which automatically detects this vulnerability. You can see the results of the query on the standard-version project here.

Impact

This issue may lead to remote code execution if a client of the library calls the vulnerable method with untrusted input.

Remediation

We recommend not using an API that can interpret a string as a shell command. For example, use child_process.execFile instead of child_process.exec.

Credit

This issue was discovered and reported by GitHub Engineer @​erik-krogh (Erik Krogh Kristensen).

Contact

You can contact the GHSL team at securitylab@github.com, please include GHSL-2020-111 in any communication regarding this issue.

Disclosure Policy

This report is subject to our coordinated disclosure policy.


Release Notes

conventional-changelog/standard-version

v8.0.1

Compare Source

v8.0.0

Compare Source

⚠ BREAKING CHANGES
  • composer.json and composer.lock will no longer be read from or bumped by default. If you need to obtain a version or write a version to these files, please use bumpFiles and/or packageFiles options accordingly.
Bug Fixes
  • composer.json and composer.lock have been removed from default package and bump files. (c934f3a), closes #​495 #​394
  • deps: update dependency conventional-changelog to v3.1.18 (#​510) (e6aeb77)
  • deps: update dependency yargs to v15.1.0 (#​518) (8f36f9e)
  • deps: update dependency yargs to v15.3.1 (#​559) (d98cd46)

Renovate configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/npm-standard-version-vulnerability branch 2 times, most recently from 2a6ca9a to 411a555 Compare August 14, 2020 23:18
@renovate renovate bot changed the title chore(deps): update dependency standard-version to v8 [security] Update dependency standard-version to v8 [SECURITY] Aug 14, 2020
@renovate renovate bot changed the title Update dependency standard-version to v8 [SECURITY] chore(deps): update dependency standard-version to v8 [security] Sep 11, 2020
@renovate renovate bot force-pushed the renovate/npm-standard-version-vulnerability branch 2 times, most recently from 3c022fb to 3be52d8 Compare September 30, 2020 20:21
@renovate renovate bot force-pushed the renovate/npm-standard-version-vulnerability branch from 3be52d8 to d6bcc19 Compare September 30, 2020 21:15
@mgechev mgechev merged commit 783af21 into master Oct 2, 2020
@renovate renovate bot deleted the renovate/npm-standard-version-vulnerability branch October 2, 2020 22:51
mgechev added a commit that referenced this pull request May 3, 2021
* 'master' of github.com:mgechev/codelyzer:
  chore(deps): update dependency @types/node to v11.15.50 (#994)
  fix(deps): update dependency codemirror to v5.59.2 (#971)
  chore(deps): update dependency @types/node to v11.15.43 (#968)
  fix(deps): update dependency codelyzer to v5.2.2 (#917)
  chore(deps): update dependency node-sass to v4.13.1 [security] (#983)
  chore(deps): update dependency @types/chai to v4.2.13 (#932)
  chore(deps): update dependency typescript to v3.9.7 (#963)
  chore(deps): update dependency standard-version to v8 [security] (#972)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants