fix: unnecesary alert for use-any when comments inside interface{} (#873

)

* feat: add rule for unused import alias

* fix: rename rule

* fix: rename rule

* fix: use-any skip comments inside interface{}

rule/use-any.go

@@ -1,9 +1,8 @@
 package rule
 
 import (
-	"go/ast"
-
 	"github.com/mgechev/revive/lint"
+	"go/ast"
 )
 
 // UseAnyRule lints given else constructs.
@@ -14,6 +13,7 @@ func (*UseAnyRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
 	walker := lintUseAny{
+		commentPositions: getCommentsPositions(file.AST.Comments),
 		onFailure: func(failure lint.Failure) {
 			failures = append(failures, failure)
 		},
@@ -30,7 +30,8 @@ func (*UseAnyRule) Name() string {
 }
 
 type lintUseAny struct {
-	onFailure func(lint.Failure)
+	commentPositions []int
+	onFailure        func(lint.Failure)
 }
 
 func (w lintUseAny) Visit(n ast.Node) ast.Visitor {
@@ -40,7 +41,13 @@ func (w lintUseAny) Visit(n ast.Node) ast.Visitor {
 	}
 
 	if len(it.Methods.List) != 0 {
-		return w // it is not and empty interface
+		return w // it is not an empty interface
+	}
+
+	for _, pos := range w.commentPositions {
+		if pos > int(it.Pos()) && pos < int(it.End()) {
+			return w // it is a comment inside the interface
+		}
 	}
 
 	w.onFailure(lint.Failure{
@@ -52,3 +59,14 @@ func (w lintUseAny) Visit(n ast.Node) ast.Visitor {
 
 	return w
 }
+
+func getCommentsPositions(commentGroups []*ast.CommentGroup) []int {
+	result := []int{}
+	for _, commentGroup := range commentGroups {
+		for _, comment := range commentGroup.List {
+			result = append(result, int(comment.Pos()))
+		}
+	}
+
+	return result
+}

testdata/use-any.go

@@ -17,6 +17,10 @@ func any2(a int) interface{} {} // MATCH /since GO 1.18 'interface{}' can be rep
 
 var ni interface{ Close() }
 
+var ni interface {
+	// Close()
+}
+
 type nt interface{ Close() }
 type na = interface{ Close() }